fix: unify answer recovery states with shared EmptyState by BigSimmo · Pull Request #802 · BigSimmo/Database

BigSimmo · 2026-07-17T20:58:40Z

Summary

Unify answer recovery empty/error states onto the shared EmptyState primitive for consistent clinical journey messaging.
Recreates closed fix: unify answer recovery states #776 / original Unify answer recovery states with shared EmptyState primitive #755 with PR-policy-compliant metadata.

Verification

Hosted Static PR checks / Build / Unit coverage / Advisory UI on predecessor heads.
npm run verify:ui evidence via hosted UI gates on predecessor heads.
UI verification not run locally in this babysit pass: relying on hosted Production UI.

Risk and rollout

Risk: low; presentation-only recovery state unification with no retrieval contract change.
Rollback: revert this PR to restore prior inline recovery markup.
Provider or production effects: None

Clinical Governance Preflight

Source-backed claims still require linked source verification before clinical use
No patient-identifiable document workflow was introduced or expanded without explicit governance approval
Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
Service-role keys and private document access remain server-only
Demo/synthetic content remains clearly separated from real clinical sources
Source metadata, review status, and outdated/unknown-source behavior remain conservative
Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Summary by CodeRabbit

New Features
- Improved answer recovery screens with clearer empty-state messaging for cancelled requests, no results, and errors.
- Added contextual actions such as retrying, focusing the question field, and searching documents.
- Added visual tones for neutral, informational, and error states.
Accessibility
- Improved status and alert announcements so important recovery messages are communicated more effectively.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

…ecovery-40ad

supabase · 2026-07-17T20:58:45Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2026-07-17T20:58:57Z

📝 Walkthrough

Walkthrough

EmptyState now supports recovery actions, live-region semantics, tone styling, and test IDs. ClinicalDashboard uses it for cancelled, no-results, and error answer states, with tests covering status and alert roles.

Changes

Answer recovery UI

Layer / File(s)	Summary
Extend EmptyState contract `src/components/ui-primitives.tsx`, `tests/ui-primitives.dom.test.tsx`	`EmptyState` supports actions, live-region roles, neutral/info/danger tones, test IDs, and tests for status and alert rendering.
Integrate answer recovery states `src/components/ClinicalDashboard.tsx`	Cancelled, no-results, and generic error states render configured `EmptyState` variants while retaining retry, rephrase, and document-search callbacks.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

BigSimmo/Database#798: Directly overlaps the ClinicalDashboard EmptyState integration and shared component API changes.

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: consolidating answer recovery states into the shared EmptyState component.
Description check	✅ Passed	The description covers summary, verification, risk/rollback, and governance preflight; only minor template details like Notes are missing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cursor/unify-answer-recovery-db17

_{Comment @coderabbitai help to get the list of available commands.}

…ecovery-db17

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/ClinicalDashboard.tsx`:
- Around line 3648-3655: Update the error EmptyState branch in ClinicalDashboard
to distinguish errors by activeModeResultKind instead of always presenting
“Answer unavailable.” Use the appropriate title and icon for document-search and
clipboard errors, while preserving the answer-specific presentation for answer
errors.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dc1fddb3-1808-42b7-802d-9563fea5fb17

📥 Commits

Reviewing files that changed from the base of the PR and between 3ff8095 and d7afb2f.

📒 Files selected for processing (3)

src/components/ClinicalDashboard.tsx
src/components/ui-primitives.tsx
tests/ui-primitives.dom.test.tsx

coderabbitai · 2026-07-17T21:03:00Z

+                ) : error ? (
+                  <EmptyState
+                    icon={CircleAlert}
+                    title="Answer unavailable"
+                    body={error}
+                    live="assertive"
+                    tone="danger"
+                    testId="answer-error"


🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Do not label every dashboard error as an answer failure.

This branch also handles document-search and clipboard errors, so those modes now display “Answer unavailable.” Select the title/icon based on activeModeResultKind, or restrict this EmptyState to answer errors.

Proposed fix

- title="Answer unavailable" + title={activeModeResultKind === "answer" ? "Answer unavailable" : "Search unavailable"}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

) : error ? (

<EmptyState

icon={CircleAlert}

title="Answer unavailable"

body={error}

live="assertive"

tone="danger"

testId="answer-error"

) : error ? (

<EmptyState

icon={CircleAlert}

title={activeModeResultKind === "answer" ? "Answer unavailable" : "Search unavailable"}

body={error}

live="assertive"

tone="danger"

testId="answer-error"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ClinicalDashboard.tsx` around lines 3648 - 3655, Update the error EmptyState branch in ClinicalDashboard to distinguish errors by activeModeResultKind instead of always presenting “Answer unavailable.” Use the appropriate title and icon for document-search and clipboard errors, while preserving the answer-specific presentation for answer errors.

CodeRabbit residual from superseded #802: non-answer modes should not show "Answer unavailable" for document-search/clipboard failures. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

#812) * fix: place Also matches after mode hubs and always show error focus Keep tools/favourites Also matches after primary hub content so the panel matches the post-results placement landed from the screenshot queue, and use focus: styles on the route error heading so recovery focus remains visible after pointer-driven failures. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: distinguish answer vs search EmptyState error titles CodeRabbit residual from superseded #802: non-answer modes should not show "Answer unavailable" for document-search/clipboard failures. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

cursoragent and others added 3 commits July 17, 2026 20:31

fix: unify answer recovery states

0991656

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into cursor/unify-answer-r…

ff8300e

…ecovery-40ad

Merge remote-tracking branch 'origin/main' into cursor/unify-answer-r…

3944835

…ecovery-40ad

cursor Bot enabled auto-merge (squash) July 17, 2026 20:59

Merge remote-tracking branch 'origin/main' into cursor/unify-answer-r…

d7afb2f

…ecovery-db17

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Jul 17, 2026

fix: land remaining PR cleanup batch onto main #798

Merged

9 tasks

BigSimmo mentioned this pull request Jul 18, 2026

fix: land unique open-PR queue onto current main #808

Merged

11 tasks

BigSimmo closed this Jul 18, 2026

auto-merge was automatically disabled July 18, 2026 06:23
Pull request was closed

cursor Bot mentioned this pull request Jul 18, 2026

fix: finish screenshot-PR residuals (Also matches order + error focus) #812

Merged

8 tasks

coderabbitai Bot mentioned this pull request Jul 18, 2026

fix: refine answer recovery message and match scope #833

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: unify answer recovery states with shared EmptyState#802

fix: unify answer recovery states with shared EmptyState#802
BigSimmo wants to merge 4 commits into
mainfrom
cursor/unify-answer-recovery-db17

BigSimmo commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

supabase Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

BigSimmo commented Jul 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Risk and rollout

Clinical Governance Preflight

Summary by CodeRabbit

Uh oh!

supabase Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BigSimmo commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading